Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Close #6421: Download try again should not crash when download does not exist #6746

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Close #6421: Download try again should not crash when download does not exist #6746

merged 1 commit into from
Apr 24, 2020

Conversation

rocketsroger
Copy link
Contributor

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@rocketsroger rocketsroger added the 🕵️‍♀️ needs review PRs that need to be reviewed label Apr 22, 2020
@codecov
Copy link

codecov bot commented Apr 22, 2020 •
edited
Loading

Codecov Report

Merging #6746 into master will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6746      +/-   ##
============================================
- Coverage     77.65%   77.57%   -0.09%     
+ Complexity     4732     4406     -326     
============================================
  Files           625      599      -26     
  Lines         23115    21690    -1425     
  Branches       3413     3110     -303     
============================================
- Hits          17951    16826    -1125     
+ Misses         3753     3584     -169     
+ Partials       1411     1280     -131
Impacted Files Coverage Δ Complexity Δ
.../feature/downloads/manager/FetchDownloadManager.kt 80.00% <100.00%> (ø) 11.00 <2.00> (+1.00)
...components/support/sync/telemetry/SyncTelemetry.kt 85.71% <0.00%> (-2.01%) 41.00% <0.00%> (ø%)
...a/components/support/migration/TelemetryHelpers.kt 88.05% <0.00%> (-0.12%) 0.00% <0.00%> (ø%)
.../mozilla/components/support/utils/DrawableUtils.kt
.../browser/engine/system/matcher/ReversibleString.kt
...ava/mozilla/components/support/utils/SafeBundle.kt
...feature/webnotifications/WebNotificationFeature.kt
...components/concept/toolbar/AutocompleteDelegate.kt
.../java/mozilla/components/support/utils/Browsers.kt
...rowser/engine/system/window/SystemWindowRequest.kt
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec54326...c5ab055. Read the comment docs.

@Amejia481 Amejia481 self-requested a review April 23, 2020 13:17
@Amejia481 Amejia481 self-assigned this Apr 23, 2020
@rocketsroger rocketsroger added work in progress Not ready to land yet. Work in progress (WIP). and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Apr 24, 2020
Amejia481
Amejia481 approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@Amejia481 Amejia481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rocketsroger rocketsroger removed the work in progress Not ready to land yet. Work in progress (WIP). label Apr 24, 2020
@rocketsroger
Copy link
Contributor Author

bors r=Amejia481

@Amejia481 Amejia481 added the 🛬 needs landing PRs that are ready to land label Apr 24, 2020
@bors
Copy link

bors bot commented Apr 24, 2020

Build succeeded:

  • complete-push

@bors bors bot merged commit 0d2fb25 into mozilla-mobile:master Apr 24, 2020
@rocketsroger rocketsroger deleted the AC_6421 branch April 24, 2020 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Amejia481 Amejia481 Amejia481 approved these changes

Assignees

@Amejia481 Amejia481

Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rocketsroger @Amejia481